Use the column name as descriptor instead of the selector #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Octanium <[email protected]>
Signed-off-by: Octanium <[email protected]>
0ctanium
commented
Nov 25, 2021
pkg/pgsql/server/query_machine.go
Outdated
| @@ -336,7 +336,7 @@ func (s *session) inferParamAndResultCols(statement string) ([]*schema.Column, [ | |||
| return nil, nil, err | |||
| } | |||
| for _, c := range cols { | |||
| resCols = append(resCols, &schema.Column{Name: c.Selector(), Type: c.Type}) | |||
| resCols = append(resCols, &schema.Column{Name: c.Column, Type: c.Type}) | |||
There was a problem hiding this comment.
I know the database/sql descriptor is the descriptor that is exposed to the client.
But for this one I don't really know what its usage is
There was a problem hiding this comment.
if just the column name is used then queries like "select t1.id, t2.id ..." could lead to wrong interpretations, that's why full descriptor "db.table.col" is used instead... but the final layer may provide a way to just fetch the column name, or some way of dealing with such conflicts...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #988